Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests (#17) #64

Merged
merged 21 commits into from
Oct 12, 2023
Merged

test: add tests (#17) #64

merged 21 commits into from
Oct 12, 2023

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Oct 9, 2023

I've not made it a draft as I want to see it running on CI 😉

@sinedied sinedied changed the title test: add tests test: add tests (#17) Oct 9, 2023
@sinedied sinedied force-pushed the tests branch 2 times, most recently from 50074e0 to c0318a8 Compare October 9, 2023 12:08
packages/search/src/lib/util/string.ts Outdated Show resolved Hide resolved
@sinedied
Copy link
Contributor Author

sinedied commented Oct 9, 2023

If the CI pass, we can merge this as it still fixes the test config and add some unit tests.
Since the chat API will change anyways, we can add the snapshot tests later after the changes

@isaacs
Copy link

isaacs commented Oct 11, 2023

npm rm @tapjs/nock
npm i @tapjs/nock@latest

Need to update nock plugin as well as tap itself, or else it dupes @tapjs/core and pulls in the wrong build plugin script.

@sinedied
Copy link
Contributor Author

I forgot about that one, probably the lack of sleep 😅
It's all fixed now, thanks a lot @isaacs for looking into it!

@sinedied sinedied merged commit 2f9bf1d into main Oct 12, 2023
@anfibiacreativa anfibiacreativa deleted the tests branch January 19, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants