Feat/use wc webapp #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manekinekko
force-pushed
the
feat/use-wc-webapp
branch
from
6174f69 to
de5cf7b
Compare
anfibiacreativa
approved these changes
Oct 16, 2023
| @@ -133,7 +164,7 @@ export class ChatComponent extends LitElement { | |||
| if (isUserMessage) { | |||
| updateChatWithMessageOrChunk(message, false); | |||
| } else { | |||
| if (this.isStreaming) { | |||
| if (this.useStream) { | |||
There was a problem hiding this comment.
conventionally booleans are named isName or hasName...do we really want to change that?
sinedied
requested changes
Oct 17, 2023
sinedied
reviewed
Oct 17, 2023
sinedied
force-pushed
the
feat/use-wc-webapp
branch
from
e6f715b to
9e37f2c
Compare
sinedied
force-pushed
the
feat/use-wc-webapp
branch
from
2c8d29f to
e33fa7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69