Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): configure CORS #71

Merged
merged 6 commits into from
Oct 12, 2023
Merged

feat(search): configure CORS #71

merged 6 commits into from
Oct 12, 2023

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Oct 9, 2023 •
edited
Loading

I need to deploy it first to test it

@sinedied sinedied marked this pull request as ready for review October 10, 2023 07:49
@sinedied
Copy link
Contributor Author

Tested and validated on deployed version

@anfibiacreativa anfibiacreativa self-requested a review October 11, 2023 11:18
anfibiacreativa
anfibiacreativa requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@anfibiacreativa anfibiacreativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at mismatching env var name. Is that an iterator? ALLOWED_ORIGIN of ALLOWED_ORIGINS? Otherwise seems to be a typo.

infra/main.parameters.json Show resolved Hide resolved
@sinedied
Copy link
Contributor Author

@anfibiacreativa I answered your comment, it's not a mismatch it's intentional as one is the input (single), and one is the output (plural) consumed by the search service.

@manekinekko
Copy link
Contributor

LGTM

@sinedied sinedied merged commit 032ee84 into main Oct 12, 2023
7 checks passed
@sinedied sinedied deleted the cors branch October 12, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anfibiacreativa anfibiacreativa anfibiacreativa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinedied @manekinekko @anfibiacreativa