Skip to content

Commit

Permalink
Add integrated vectorization settings to app settings in bicep. (#833)
Browse files Browse the repository at this point in the history
  • Loading branch information
superhindupur authored May 8, 2024
1 parent aa0636e commit fd6e2a2
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ assignees: ''

# Motivation

A clear and concise description of why this feature would be useful and the value it would bring.
A clear and concise description of why this feature would be useful and the value it would bring.
Explain any alternatives considered and why they are not sufficient.

# How would you feel if this feature request was implemented?

_Share a gif from [giphy](https://giphy.com/) to tells us how you'd feel_
_Share a gif from [giphy](https://giphy.com/) to tells us how you'd feel. Format: ![alt_text](https://media.giphy.com/media/xxx/giphy.gif)_

# Requirements

Expand Down
1 change: 1 addition & 0 deletions docs/LOCAL_DEPLOYMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ Execute the above [shell command](#L81) to run the function locally. You may nee
|AZURE_SEARCH_FIELDS_TAG|tag|Field from your Azure AI Search index that contains tags for the document. `tag` if you don't have a specific requirement.|
|AZURE_SEARCH_FIELDS_METADATA|metadata|Field from your Azure AI Search index that contains metadata for the document. `metadata` if you don't have a specific requirement.|
|AZURE_SEARCH_FILTER||Filter to apply to search queries.|
|AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION ||Whether to use [Integrated Vectorization](https://learn.microsoft.com/en-us/azure/search/vector-search-integrated-vectorization)|
|AZURE_OPENAI_RESOURCE||the name of your Azure OpenAI resource|
|AZURE_OPENAI_MODEL||The name of your model deployment|
|AZURE_OPENAI_MODEL_NAME|gpt-35-turbo|The name of the model|
Expand Down
14 changes: 14 additions & 0 deletions infra/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,7 @@ module web './app/web.bicep' = if (hostingModel == 'code') {
AZURE_SEARCH_FILTER: azureSearchFilter
AZURE_SEARCH_TITLE_COLUMN: azureSearchTitleColumn
AZURE_SEARCH_URL_COLUMN: azureSearchUrlColumn
AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION: azureSearchUseIntegratedVectorization
AZURE_SPEECH_SERVICE_NAME: speechServiceName
AZURE_SPEECH_SERVICE_REGION: location
AZURE_SPEECH_RECOGNIZER_LANGUAGES: recognizedLanguages
Expand Down Expand Up @@ -585,6 +586,7 @@ module web_docker './app/web.bicep' = if (hostingModel == 'container') {
AZURE_SEARCH_FILTER: azureSearchFilter
AZURE_SEARCH_TITLE_COLUMN: azureSearchTitleColumn
AZURE_SEARCH_URL_COLUMN: azureSearchUrlColumn
AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION: azureSearchUseIntegratedVectorization
AZURE_SPEECH_SERVICE_NAME: speechServiceName
AZURE_SPEECH_SERVICE_REGION: location
AZURE_SPEECH_RECOGNIZER_LANGUAGES: recognizedLanguages
Expand Down Expand Up @@ -648,6 +650,9 @@ module adminweb './app/adminweb.bicep' = if (hostingModel == 'code') {
AZURE_SEARCH_FILTER: azureSearchFilter
AZURE_SEARCH_TITLE_COLUMN: azureSearchTitleColumn
AZURE_SEARCH_URL_COLUMN: azureSearchUrlColumn
AZURE_SEARCH_DATASOURCE_NAME: azureSearchDatasource
AZURE_SEARCH_INDEXER_NAME: azureSearchIndexer
AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION: azureSearchUseIntegratedVectorization
BACKEND_URL: 'https://${functionName}.azurewebsites.net'
DOCUMENT_PROCESSING_QUEUE_NAME: queueName
FUNCTION_KEY: clientKey
Expand Down Expand Up @@ -710,6 +715,9 @@ module adminweb_docker './app/adminweb.bicep' = if (hostingModel == 'container')
AZURE_SEARCH_FILTER: azureSearchFilter
AZURE_SEARCH_TITLE_COLUMN: azureSearchTitleColumn
AZURE_SEARCH_URL_COLUMN: azureSearchUrlColumn
AZURE_SEARCH_DATASOURCE_NAME: azureSearchDatasource
AZURE_SEARCH_INDEXER_NAME: azureSearchIndexer
AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION: azureSearchUseIntegratedVectorization
BACKEND_URL: 'https://${functionName}-docker.azurewebsites.net'
DOCUMENT_PROCESSING_QUEUE_NAME: queueName
FUNCTION_KEY: clientKey
Expand Down Expand Up @@ -789,6 +797,9 @@ module function './app/function.bicep' = if (hostingModel == 'code') {
AZURE_OPENAI_API_VERSION: azureOpenAIApiVersion
AZURE_SEARCH_INDEX: azureSearchIndex
AZURE_SEARCH_SERVICE: 'https://${azureAISearchName}.search.windows.net'
AZURE_SEARCH_DATASOURCE_NAME: azureSearchDatasource
AZURE_SEARCH_INDEXER_NAME: azureSearchIndexer
AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION: azureSearchUseIntegratedVectorization
DOCUMENT_PROCESSING_QUEUE_NAME: queueName
ORCHESTRATION_STRATEGY: orchestrationStrategy
LOGLEVEL: logLevel
Expand Down Expand Up @@ -833,6 +844,9 @@ module function_docker './app/function.bicep' = if (hostingModel == 'container')
AZURE_OPENAI_API_VERSION: azureOpenAIApiVersion
AZURE_SEARCH_INDEX: azureSearchIndex
AZURE_SEARCH_SERVICE: 'https://${azureAISearchName}.search.windows.net'
AZURE_SEARCH_DATASOURCE_NAME: azureSearchDatasource
AZURE_SEARCH_INDEXER_NAME: azureSearchIndexer
AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION: azureSearchUseIntegratedVectorization
DOCUMENT_PROCESSING_QUEUE_NAME: queueName
ORCHESTRATION_STRATEGY: orchestrationStrategy
LOGLEVEL: logLevel
Expand Down
2 changes: 2 additions & 0 deletions infra/main.bicepparam
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ param azureOpenAIEmbeddingModelCapacity = int(readEnvironmentVariable('AZURE_OPE

param computerVisionLocation = readEnvironmentVariable('AZURE_COMPUTER_VISION_LOCATION', '')

param azureSearchUseIntegratedVectorization = bool(readEnvironmentVariable('AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION', 'false'))

// The following are being renamed to align with the new naming convention
// we manipulate existing resources here to maintain backwards compatibility

Expand Down
16 changes: 15 additions & 1 deletion infra/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.26.170.59819",
"templateHash": "7867283002505805735"
"templateHash": "13417848583364624457"
}
},
"parameters": {
Expand Down Expand Up @@ -1966,6 +1966,7 @@
"AZURE_SEARCH_FILTER": "[parameters('azureSearchFilter')]",
"AZURE_SEARCH_TITLE_COLUMN": "[parameters('azureSearchTitleColumn')]",
"AZURE_SEARCH_URL_COLUMN": "[parameters('azureSearchUrlColumn')]",
"AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION": "[parameters('azureSearchUseIntegratedVectorization')]",
"AZURE_SPEECH_SERVICE_NAME": "[parameters('speechServiceName')]",
"AZURE_SPEECH_SERVICE_REGION": "[parameters('location')]",
"AZURE_SPEECH_RECOGNIZER_LANGUAGES": "[parameters('recognizedLanguages')]",
Expand Down Expand Up @@ -2901,6 +2902,7 @@
"AZURE_SEARCH_FILTER": "[parameters('azureSearchFilter')]",
"AZURE_SEARCH_TITLE_COLUMN": "[parameters('azureSearchTitleColumn')]",
"AZURE_SEARCH_URL_COLUMN": "[parameters('azureSearchUrlColumn')]",
"AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION": "[parameters('azureSearchUseIntegratedVectorization')]",
"AZURE_SPEECH_SERVICE_NAME": "[parameters('speechServiceName')]",
"AZURE_SPEECH_SERVICE_REGION": "[parameters('location')]",
"AZURE_SPEECH_RECOGNIZER_LANGUAGES": "[parameters('recognizedLanguages')]",
Expand Down Expand Up @@ -3835,6 +3837,9 @@
"AZURE_SEARCH_FILTER": "[parameters('azureSearchFilter')]",
"AZURE_SEARCH_TITLE_COLUMN": "[parameters('azureSearchTitleColumn')]",
"AZURE_SEARCH_URL_COLUMN": "[parameters('azureSearchUrlColumn')]",
"AZURE_SEARCH_DATASOURCE_NAME": "[parameters('azureSearchDatasource')]",
"AZURE_SEARCH_INDEXER_NAME": "[parameters('azureSearchIndexer')]",
"AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION": "[parameters('azureSearchUseIntegratedVectorization')]",
"BACKEND_URL": "[format('https://{0}.azurewebsites.net', parameters('functionName'))]",
"DOCUMENT_PROCESSING_QUEUE_NAME": "[variables('queueName')]",
"FUNCTION_KEY": "[variables('clientKey')]",
Expand Down Expand Up @@ -4759,6 +4764,9 @@
"AZURE_SEARCH_FILTER": "[parameters('azureSearchFilter')]",
"AZURE_SEARCH_TITLE_COLUMN": "[parameters('azureSearchTitleColumn')]",
"AZURE_SEARCH_URL_COLUMN": "[parameters('azureSearchUrlColumn')]",
"AZURE_SEARCH_DATASOURCE_NAME": "[parameters('azureSearchDatasource')]",
"AZURE_SEARCH_INDEXER_NAME": "[parameters('azureSearchIndexer')]",
"AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION": "[parameters('azureSearchUseIntegratedVectorization')]",
"BACKEND_URL": "[format('https://{0}-docker.azurewebsites.net', parameters('functionName'))]",
"DOCUMENT_PROCESSING_QUEUE_NAME": "[variables('queueName')]",
"FUNCTION_KEY": "[variables('clientKey')]",
Expand Down Expand Up @@ -7405,6 +7413,9 @@
"AZURE_OPENAI_API_VERSION": "[parameters('azureOpenAIApiVersion')]",
"AZURE_SEARCH_INDEX": "[parameters('azureSearchIndex')]",
"AZURE_SEARCH_SERVICE": "[format('https://{0}.search.windows.net', parameters('azureAISearchName'))]",
"AZURE_SEARCH_DATASOURCE_NAME": "[parameters('azureSearchDatasource')]",
"AZURE_SEARCH_INDEXER_NAME": "[parameters('azureSearchIndexer')]",
"AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION": "[parameters('azureSearchUseIntegratedVectorization')]",
"DOCUMENT_PROCESSING_QUEUE_NAME": "[variables('queueName')]",
"ORCHESTRATION_STRATEGY": "[parameters('orchestrationStrategy')]",
"LOGLEVEL": "[parameters('logLevel')]"
Expand Down Expand Up @@ -8622,6 +8633,9 @@
"AZURE_OPENAI_API_VERSION": "[parameters('azureOpenAIApiVersion')]",
"AZURE_SEARCH_INDEX": "[parameters('azureSearchIndex')]",
"AZURE_SEARCH_SERVICE": "[format('https://{0}.search.windows.net', parameters('azureAISearchName'))]",
"AZURE_SEARCH_DATASOURCE_NAME": "[parameters('azureSearchDatasource')]",
"AZURE_SEARCH_INDEXER_NAME": "[parameters('azureSearchIndexer')]",
"AZURE_SEARCH_USE_INTEGRATED_VECTORIZATION": "[parameters('azureSearchUseIntegratedVectorization')]",
"DOCUMENT_PROCESSING_QUEUE_NAME": "[variables('queueName')]",
"ORCHESTRATION_STRATEGY": "[parameters('orchestrationStrategy')]",
"LOGLEVEL": "[parameters('logLevel')]"
Expand Down

0 comments on commit fd6e2a2

Please sign in to comment.