Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed lint issue #1396

Merged
merged 5 commits into from
Oct 10, 2024
Merged

fix: fixed lint issue #1396

merged 5 commits into from
Oct 10, 2024

Conversation

AjitPadhi-Microsoft
Copy link
Contributor

Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

@Fr4nc3 Fr4nc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjitPadhi-Microsoft can you add back the lint test to github/workflow/test.yml

Copy link

github-actions bot commented Oct 10, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/chat_history
   auth_utils.py282317%7, 10, 12, 14, 17, 19–24, 26, 30–33, 35–36, 38, 40–43
   cosmosdb.py1069114%16–22, 25–27, 29, 31–32, 35–36, 38–39, 42–43, 46, 51–55, 60–63, 65, 68, 78–80, 82, 85–87, 89, 92, 95–96, 99, 101, 105–109, 112–113, 116–119, 121–122, 125, 127, 130, 134–136, 139, 142–143, 145, 148, 159–160, 162–163, 165–170, 172, 175, 178–181, 183, 186, 190–192, 195, 197
   sample_user.py110%1
code/backend/batch/utilities/helpers
   azure_search_helper.py570100% 
TOTAL310491070% 

Tests Skipped Failures Errors Time
301 0 💤 0 ❌ 0 🔥 59.476s ⏱️

@AjitPadhi-Microsoft
Copy link
Contributor Author

@Fr4nc3 Updated with minor unit test fix. Please review and merge. Thanks.

@Fr4nc3 Fr4nc3 self-requested a review October 10, 2024 13:13
@Fr4nc3 Fr4nc3 added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 28e628a Oct 10, 2024
9 checks passed
@Fr4nc3 Fr4nc3 deleted the PSL-8930 branch October 10, 2024 13:17
Copy link

github-actions bot commented Nov 4, 2024

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants