Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Warning message displayed twice in chat history update #1452

Closed

Conversation

Prasanjeet-Microsoft
Copy link
Contributor

Purpose

  • Fixed issue with duplicate warning messages in chat history update

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

  1. Deploy CWYD with GPT 4o
  2. Go to CWYD Admin and enable chat history if not enabled
  3. Go to CWYD web url and save chat history conversations
  4. Click on Show chat history button and click on Edit icon for a chat thread
  5. Disconnect from network
  6. Update the text in chat thread title and click on Tick icon
  7. Observe the warning message
  8. The warning message "Error: could not rename file" should be displayed only once.

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL310991570% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
301 0 💤 0 ❌ 0 🔥 49.665s ⏱️

@Prasanjeet-Microsoft Prasanjeet-Microsoft added the invalid This doesn't seem right label Oct 30, 2024
@Prasanjeet-Microsoft Prasanjeet-Microsoft deleted the PSL-BUG-9545 branch November 12, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants