Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci workflow fix for Bicep deployment #1460

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

Roopan-Microsoft
Copy link
Contributor

@Roopan-Microsoft Roopan-Microsoft commented Nov 4, 2024

Purpose

  • Fix provided for CI workflow where resource group is creating automatically from the GitHub variables.

Does this introduce a breaking change?

  • Yes
  • No

What to Check

CI workflow - Automated

@Roopan-Microsoft Roopan-Microsoft changed the title Fix: ci workflow fix for Bicep deployment fix: ci workflow fix for Bicep deployment Nov 4, 2024
@Roopan-Microsoft Roopan-Microsoft changed the title fix: ci workflow fix for Bicep deployment fix:ci workflow fix for Bicep deployment Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL310991570% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
301 0 💤 0 ❌ 0 🔥 50.994s ⏱️

@Roopan-Microsoft Roopan-Microsoft changed the title fix:ci workflow fix for Bicep deployment fix: ci workflow fix for Bicep deployment Nov 4, 2024
@Roopan-Microsoft Roopan-Microsoft added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 670488d Nov 4, 2024
9 of 10 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the ci-workflowfix branch November 4, 2024 15:34
@ross-p-smith
Copy link
Collaborator

@Roopan-Microsoft - I dont think this will fix the underlying problem. We have now added an extra step that developers have to do - create a resource group. Why has the creation of the RG been removed from the arm/bicep?

Copy link

github-actions bot commented Nov 4, 2024

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants