Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Warning message displayed twice in chat history update #1630

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Pavan-Microsoft
Copy link
Contributor

Purpose

Fixed issue with duplicate warning messages in chat history update

Bug 9545: [QA] - CWYD - Warning message displayed twice in chat history update

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Deploy CWYD with GPT 4o
Go to CWYD Admin and enable chat history if not enabled
Go to CWYD web url and save chat history conversations
Click on Show chat history button and click on Edit icon for a chat thread
Disconnect from network
Update the text in chat thread title and click on Tick icon
Observe the warning message
The warning message "Error: could not rename file" should be displayed only once.

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL381985777% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
395 0 💤 0 ❌ 0 🔥 52.507s ⏱️

@Roopan-Microsoft Roopan-Microsoft merged commit 3789d45 into dev Jan 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants