Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run black/flake8 against code base #243

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Run black/flake8 against code base #243

merged 6 commits into from
Jan 31, 2024

Conversation

ross-p-smith
Copy link
Collaborator

Purpose

I would like to add black to fix basic python formatting issues and then also run flake8 as part of a git pre-commit. In order to do this we need the code to adhere to the rules that black and flake8 run.

This PR has had black and then flake8 run against it so that another PR can turn the pre-commit check on.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@ross-p-smith ross-p-smith mentioned this pull request Jan 30, 2024
Merged
@ross-p-smith ross-p-smith marked this pull request as draft January 30, 2024 17:34
@ross-p-smith ross-p-smith marked this pull request as ready for review January 30, 2024 19:16
adamdougal
adamdougal approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

LGTM! I'll leave to you to merge incase you need to do any additional testing

@ross-p-smith ross-p-smith mentioned this pull request Jan 31, 2024
Closed
@ross-p-smith ross-p-smith added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit 30051be Jan 31, 2024
2 checks passed
@ross-p-smith ross-p-smith deleted the ross/black branch January 31, 2024 23:10
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
@ross-p-smith
Run black/flake8 against code base (Azure-Samples#243)
b2f1c8a 
* Run black against code base

* Amending imports

* Add flake8 config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdougal adamdougal adamdougal approved these changes

@ruoccofabrizio ruoccofabrizio Awaiting requested review from ruoccofabrizio

Assignees

@ross-p-smith ross-p-smith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ross-p-smith @adamdougal