Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix generate_arm_templates.sh script, reformat all Bicep files #922

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: Fix generate_arm_templates.sh script, reformat all Bicep files #922

merged 1 commit into from
May 15, 2024

Conversation

cecheta
Copy link
Collaborator

@cecheta cecheta commented May 15, 2024 •
edited
Loading

Purpose

  • Fixes the generate_arm_templates.sh script, which was failing silently
  • Format all Bicep files

There are no actual changes to the infra.

Does this introduce a breaking change?

  • Yes
  • No

@cecheta cecheta changed the title Fix: Fix generate_arm_templates.sh script, reformat all Bicep files fix: Fix generate_arm_templates.sh script, reformat all Bicep files May 15, 2024
@github-actions GitHub Actions
Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL238367371% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
194 0 💤 0 ❌ 0 🔥 12.738s ⏱️

gaurarpit
gaurarpit approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@gaurarpit gaurarpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, how do we test this ?

@cecheta
Copy link
Collaborator Author

cecheta commented May 15, 2024

looks good, how do we test this ?

I quite crudely ran this:

for FILE in $(find . -name '*.bicep'); do
  echo '' >> $FILE
done

Then I made a new commit

@cecheta cecheta added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 8c46627 May 15, 2024
11 of 13 checks passed
@cecheta cecheta deleted the cecheta/bicep-format branch May 15, 2024 16:52
@frtibble frtibble mentioned this pull request May 15, 2024
Closed
liammoat pushed a commit that referenced this pull request May 16, 2024
@cecheta @liammoat
fix: Fix generate_arm_templates.sh script, reformat all Bicep files (#…
e790daa 
…922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurarpit gaurarpit gaurarpit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cecheta @gaurarpit