Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Investigate pylint for PEP8 #925

Merged
merged 2 commits into from
May 16, 2024
Merged

style: Investigate pylint for PEP8 #925

merged 2 commits into from
May 16, 2024

Conversation

ross-p-smith
Copy link
Collaborator

Purpose

Wanted to investigate the benefit of using pylint which seems to give us better vscode integration.

This PR is more for discussion as it relates #864

@ross-p-smith ross-p-smith requested a review from gaurarpit May 15, 2024 23:05
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code
   app.py14140%5–8, 10–11, 14, 17–19, 22, 24, 26–27
   create_app.py130397%202, 207, 330
code/backend
   Admin.py21210%5–9, 11, 13–14, 17, 20–21, 23–24, 27, 34, 41, 44–46, 48, 50
TOTAL240067371% 

Tests Skipped Failures Errors Time
196 0 💤 0 ❌ 0 🔥 12.470s ⏱️

@ross-p-smith ross-p-smith requested a review from adamdougal May 16, 2024 08:11
gaurarpit
gaurarpit reviewed May 16, 2024
View reviewed changes
code/app.py Show resolved Hide resolved
@ross-p-smith ross-p-smith added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 0ed6ffe May 16, 2024
9 checks passed
@ross-p-smith ross-p-smith deleted the ross/pylint branch May 16, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaurarpit gaurarpit gaurarpit approved these changes

@adamdougal adamdougal Awaiting requested review from adamdougal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ross-p-smith @gaurarpit