Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error viewing images in Explore Data page #936

Merged
merged 3 commits into from
May 17, 2024
Merged

fix: Error viewing images in Explore Data page #936

merged 3 commits into from
May 17, 2024

Conversation

cecheta
Copy link
Collaborator

@cecheta cecheta commented May 17, 2024 •
edited
Loading

Closes #929

Purpose

  • Fixes error where images uploaded with advanced image processing do not display in the Admin app, as they do not have a chunk ID in their metadata

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Enable advanced image processing
  • Upload image
  • View data in Explore Data page

image

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/search
   azure_search_handler.py58296%24, 30
TOTAL243468471% 

Tests Skipped Failures Errors Time
203 0 💤 0 ❌ 0 🔥 12.537s ⏱️

@cecheta cecheta force-pushed the cecheta/images-error branch from 21b35e6 to 1a5c1d9 Compare May 17, 2024 09:15
@cecheta cecheta force-pushed the cecheta/images-error branch from 79d1a9f to 41a46aa Compare May 17, 2024 09:33
adamdougal
adamdougal approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cecheta cecheta added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 0d12d63 May 17, 2024
9 checks passed
@cecheta cecheta deleted the cecheta/images-error branch May 17, 2024 09:49
@frtibble frtibble mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdougal adamdougal adamdougal approved these changes

@superhindupur superhindupur Awaiting requested review from superhindupur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to view images in Explore Data tab in Admin app
2 participants
@cecheta @adamdougal