Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cisco umbrella playbook changes and repackage #11603

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Cisco umbrella playbook changes and repackage #11603

wants to merge 9 commits into from

Conversation

v-amolpatil
Copy link
Contributor

@v-amolpatil v-amolpatil commented Dec 26, 2024 •
edited
Loading

Required items, please complete

Change(s):

  • Playbook version changes for below 3 playbooks. Re-structrucing of folders, update readme for all playbooks with images.

    1. AddIpToDestinationList
    2. AssignPolicyToIdentity
    3. GetDomainInfo
    4. There is no change in BlockDomain playbook and its custom connector as the API is not deprecated for Enforcement.

Reason for Change(s):

  • V1 version is deprecated and upgraded to newer version v2 and updated readme links and its code. Repackaged solution as well.
  • This new version has lot of changes in legacy urls so we updated this as well.

Version Updated:

  • NA

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@v-amolpatil v-amolpatil added Playbook Playbook specialty review needed Solution Solution specialty review needed labels Dec 26, 2024
@v-amolpatil v-amolpatil marked this pull request as ready for review December 26, 2024 10:53
@v-amolpatil v-amolpatil requested review from a team as code owners December 26, 2024 10:53
rahul0216
rahul0216 reviewed Dec 30, 2024
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes mostly looks good. There are few spelling mistakes in readme files. Please correct those.

Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AssignPolicyToIdentity/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-GetDomainInfo/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-AddIpToDestinationList/readme.md Outdated Show resolved Hide resolved
Solutions/CiscoUmbrella/Playbooks/Playbooks/CiscoUmbrella-GetDomainInfo/readme.md Outdated Show resolved Hide resolved
rahul0216
rahul0216 previously approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul0216 rahul0216 rahul0216 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rahul0216 rahul0216

@manishkumar1991 manishkumar1991

@v-amolpatil v-amolpatil

Labels
Content-Package Playbook Playbook specialty review needed Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-amolpatil @rahul0216 @manishkumar1991