-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IoT] Add --min-tls-version
to az iot hub update
#30710
Open
vilit1
wants to merge
5
commits into
Azure:dev
Choose a base branch
from
vilit1:iothub_mintls_upgrade
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilit1
requested review from
digimaun,
zhoxing-ms and
yanzhudd
as code owners
January 23, 2025 22:48
️✔️AzureCLI-FullTest
|
Hi @vilit1, |
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
iot hub update | cmd iot hub update added parameter min_tls_version |
Thank you for your contribution! We will review the pull request and get back to you soon. |
vilit1
changed the title
[IoT] Add --min-tls-version to
[IoT] Add Jan 23, 2025
az iot hub update
--min-tls-version
to az iot hub update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az iot hub update
Description
Adds a new parameter
--min-tls-version
to theaz iot hub update
command. This will allow users to update their min tls version in a cleaner way.Note this also has a merge with #30334 since it is required for the tests to be run live.
Testing Guide
Added the min tls version update to the integration tests
History Notes
n/a
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.