Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version reports it is old (Target: main) #4206

Closed
wants to merge 21 commits into from

Conversation

VineethReyya
Copy link
Contributor

@VineethReyya VineethReyya commented Nov 27, 2024

Issue describing the changes in this PR

when we install Azure Function Core Tool via chocolatey, the shim is generating twice as we have 3.exe files (in root folder inproc6 and inproc8 folder). Now we have added additional checks to ignore func.exe from subfolders (inproc6 and inproc8 folder) and generate shim for func.exe in root directory.
resolves #3776

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@VineethReyya VineethReyya requested a review from a team as a code owner November 27, 2024 04:55
@VineethReyya VineethReyya linked an issue Nov 27, 2024 that may be closed by this pull request
kshyju
kshyju previously approved these changes Nov 27, 2024
Copy link
Member

@kshyju kshyju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aishwaryabh Do we know how to test this change?

@VineethReyya
Copy link
Contributor Author

VineethReyya commented Dec 5, 2024

@kshyju @aishwaryabh please review this PR when you have a moment?

@VineethReyya VineethReyya requested a review from kshyju December 5, 2024 10:12
aishwaryabh
aishwaryabh previously approved these changes Dec 6, 2024
@VineethReyya VineethReyya requested a review from kshyju December 9, 2024 10:06
@VineethReyya
Copy link
Contributor Author

created a new PR . Hence closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants