Adding .NET 6 Binaries for VS OSX Artifacts #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soninaren
approved these changes
Dec 18, 2024
aishwaryabh
merged commit e485898
into
aibhandari/custom-host-e2e-tests
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #4203
Instead of having the mac custom host, we decided to have the .NET 6 binaries for OSX artifacts be deployed as part of the tooling feed VS release. Although signing in the osx custom host works today, there is an issue being hit when trying to test E2E. Therefore, today the value in the tooling feed is hardcoded as a previously released .NET 6 inproc version. This change allows the tooling feed to at least release the latest bits for the OSX artifacts.
Note this is also targeting
aibhandari/custom-host-e2e-testsas I have some major refactoring/changes that I made to the ArtifactAssembler that I wanted to preserve here.Pull request checklist