Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-vulernabilities.ps1 to skip packages specified in JSON file #4218

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

aishwaryabh
Copy link
Contributor

@aishwaryabh aishwaryabh commented Jan 3, 2025

Issue describing the changes in this PR

The core tools pipeline today is blocked due to the CVE for DotNetZip. Brett has a PR out for resolving the changes here, but in order to unblock the daily builds and pending PRs, I have created a workaround for any CVEs that we want to skip when running the security vulnerability check to be specified in skipPackagesCve.json.

Please note that any CVEs that have been addressed after will have to be removed from the JSON file. If the CVE is resolved and the package is not removed from the JSON file, the security vulnerability check will fail.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@aishwaryabh aishwaryabh requested a review from a team as a code owner January 3, 2025 21:16
@aishwaryabh aishwaryabh merged commit 6f1f4ad into main Jan 6, 2025
10 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/update-check-vulnerabilities branch January 6, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants