Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check environment for 'FUNCTIONS_WORKER_RUNTIME' on start #4219

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Check environment for 'FUNCTIONS_WORKER_RUNTIME' on start #4219

merged 7 commits into from
Jan 8, 2025
+73 −139

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Jan 7, 2025 •
edited
Loading

Issue describing the changes in this PR

resolves #4193

There was a regression in a previous core tools release where the environment was no longer being check for FUNCTIONS_WORKER_RUNTIME. This PR fixes this by checking for the worker runtime in the environment during the start operation. This PR also cleans up the tests for "MissingLocalSettingsJson".

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version (tbd if this needs to be backported)
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@liliankasem liliankasem requested a review from a team as a code owner January 7, 2025 01:25
@liliankasem liliankasem mentioned this pull request Jan 7, 2025
Closed
5 tasks
aishwaryabh
aishwaryabh previously approved these changes Jan 7, 2025
View reviewed changes
fabiocav
fabiocav previously approved these changes Jan 7, 2025
View reviewed changes
@liliankasem liliankasem dismissed stale reviews from fabiocav and aishwaryabh via 90438bd January 7, 2025 19:33
fabiocav
fabiocav previously approved these changes Jan 7, 2025
View reviewed changes
aishwaryabh
aishwaryabh previously approved these changes Jan 7, 2025
View reviewed changes
@liliankasem liliankasem merged commit c09a203 into main Jan 8, 2025
10 checks passed
@liliankasem liliankasem deleted the liliankasem/worker-runtime-envvar branch January 8, 2025 22:24
@liliankasem liliankasem mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satvu satvu satvu approved these changes

@kshyju kshyju kshyju approved these changes

@aishwaryabh aishwaryabh aishwaryabh left review comments

@fabiocav fabiocav fabiocav left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@4 version broken by a patch release
5 participants
@liliankasem @kshyju @fabiocav @satvu @aishwaryabh