Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure only root level func.exe is symlinked in Chocolatey package #4223

Merged

Conversation

VineethReyya
Copy link
Contributor

Issue describing the changes in this PR

Part I: when we install Azure Function Core Tool via chocolatey, the shim is generating twice as we have 3.exe files (in root folder inproc6 and inproc8 folder). Now we have added additional checks to ignore func.exe from subfolders (inproc6 and inproc8 folder) and generate shim for func.exe in root directory.
resolves #3776

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@VineethReyya VineethReyya requested a review from a team as a code owner January 8, 2025 18:32
@VineethReyya VineethReyya linked an issue Jan 8, 2025 that may be closed by this pull request
@VineethReyya
Copy link
Contributor Author

@liliankasem could you please review the changes.

@liliankasem liliankasem changed the title 3776 - Latest version reports it is old - chocolatey changes (Part I) Ensure only root level func.exe is symlinked in Chocolatey package Jan 8, 2025
@VineethReyya VineethReyya merged commit 2619642 into main Jan 9, 2025
10 checks passed
@VineethReyya VineethReyya deleted the 3776-latest-version-reports-it-is-old---chocolatey branch January 9, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version reports it is old
3 participants