Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VersionHelper to utilize GH release tag for version check #4224

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Update VersionHelper to utilize GH release tag for version check #4224

merged 6 commits into from
Jan 23, 2025

Conversation

VineethReyya
Copy link
Contributor

@VineethReyya VineethReyya commented Jan 8, 2025 •
edited
Loading

Issue describing the changes in this PR

Part II: we are getting message of older version when we install Azure Function Core Tool latest version via Windows and macOS.
To resolve this In VersionHelper.cs 'IsRunningOlderversion' method we have changed the logic to get the Latest Release version from GitHubReleaseApiUrl by extracting it from tag_name and compare it with Cliversion

resolves #3776

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@VineethReyya VineethReyya requested a review from a team as a code owner January 8, 2025 19:18
@VineethReyya VineethReyya linked an issue Jan 8, 2025 that may be closed by this pull request
Latest version reports it is old #3776
Closed
@VineethReyya VineethReyya mentioned this pull request Jan 8, 2025
Closed
5 tasks
@VineethReyya
Copy link
Contributor Author

@liliankasem could you review when you have a moment

@liliankasem liliankasem changed the title 3776 - Latest version reports it is old - Part II Update VersionHelper to utilize GH release tag for version check Jan 9, 2025
@VineethReyya
Copy link
Contributor Author

@liliankasem could you please review when you have a moment.
Thanks

@saadalia saadalia mentioned this pull request Jan 19, 2025
Closed
@VineethReyya
Copy link
Contributor Author

VineethReyya commented Jan 21, 2025 •
edited
Loading

@liliankasem @saadalia could you guys please help me out in reviewing suggested changes.
Thanks

@fabiocav fabiocav linked an issue Jan 22, 2025 that may be closed by this pull request
func tools says latest stable is not latest #4229
Closed
@fabiocav fabiocav mentioned this pull request Jan 22, 2025
Closed
@fabiocav fabiocav requested a review from aishwaryabh January 22, 2025 21:44
@fabiocav fabiocav linked an issue Jan 22, 2025 that may be closed by this pull request
"You are using an old Core Tools version. Please upgrade to the latest version." in the latest version #4235
Closed
@liliankasem liliankasem merged commit 0eb0036 into main Jan 23, 2025
10 checks passed
@liliankasem liliankasem deleted the 3776-latest-version-reports-it-is-old-Part-II branch January 23, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadalia saadalia saadalia left review comments

@aishwaryabh aishwaryabh aishwaryabh approved these changes

@liliankasem liliankasem liliankasem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@VineethReyya @liliankasem @saadalia @aishwaryabh