Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress unapplicable CodeQL AAD issues #10701

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Suppress unapplicable CodeQL AAD issues #10701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/WebJobs.Script.WebHost/Security/Authentication/Jwt/ScriptJwtBearerExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ private static IEnumerable<string> GetValidAudiences()
public static TokenValidationParameters CreateTokenValidationParameters()
{
var signingKeys = SecretsUtility.GetTokenIssuerSigningKeys();

// There are two separate CodeQL alerts for the same issue. The double comment on same line is intentional.
// CodeQL [SM04555] this handler does not verify AAD tokens. It verifies tokens issued by the platform. // CodeQL [SM04554] this handler does not verify AAD tokens. It verifies tokens issued by the platform.
var result = new TokenValidationParameters();
if (signingKeys.Length > 0)
{
Expand Down
Loading