Skip to content

Commit

Permalink
Disable certs while service principal repaired.
Browse files Browse the repository at this point in the history
  • Loading branch information
anthonyvercolano committed Sep 29, 2020
1 parent e66e023 commit 1148eac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
8 changes: 4 additions & 4 deletions e2etests/test/server_validation.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('Service Client', function () {
require('azure-iothub').Amqp,
require('azure-iothub').AmqpWs
].forEach(function (Transport) {
it('Service client will fail with SAS token over ' + Transport.name + ' using a shared access signature', function(done) {
it.skip('Service client will fail with SAS token over ' + Transport.name + ' using a shared access signature', function(done) {
var connStr = serviceSdk.ConnectionString.parse(hubConnectionString);
var sas = serviceSas.create(connStr.HostName, connStr.SharedAccessKeyName, connStr.SharedAccessKey, anHourFromNow()).toString();
var serviceClient = serviceSdk.Client.fromSharedAccessSignature(sas, Transport);
Expand All @@ -58,7 +58,7 @@ describe('Service Client', function () {
});
});

it('Service client will fail with connection string over ' + Transport.name + ' using a connection string', function(done) {
it.skip('Service client will fail with connection string over ' + Transport.name + ' using a connection string', function(done) {
var serviceClient = serviceSdk.Client.fromConnectionString(hubConnectionString, Transport);
serviceClient.open(function(err) {
if (err) {
Expand All @@ -78,7 +78,7 @@ describe('Registry', function () {
var deviceIdOnly = {
deviceId: uuid.v4()
};
it('Fails to create a device', function (done){
it.skip('Fails to create a device', function (done){
var registry = Registry.fromConnectionString(hubConnectionString);
registry.create(deviceIdOnly, function(err) {
correctDisconnectMessage(err, done);
Expand All @@ -98,7 +98,7 @@ describe('Device Client', function() {
mqttModule.MqttWs
].forEach(function (deviceTransport) {
describe('Over ' + deviceTransport.name, function () {
it('Fails to open a device', function(done) {
it.skip('Fails to open a device', function(done) {
var deviceClient = deviceSdk.Client.fromConnectionString(deviceConnectionString, deviceTransport);
deviceClient.setRetryPolicy(new NoRetry());
deviceClient.sendEvent(originalMessage, function(err) {
Expand Down
2 changes: 1 addition & 1 deletion provisioning/e2e/_server_validation.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('Invalid Certificate Validation', function() {
}
}
};
it('Should fail to create enrollment', function(done) {
it.skip('Should fail to create enrollment', function(done) {
var dpsServiceClient = provisioningServiceClient.fromConnectionString(process.env.DPS_CONN_STRING_INVALID_CERT);
dpsServiceClient.createOrUpdateIndividualEnrollment(enrollment1, function(err) {
correctDisconnectMessage(err, done);
Expand Down
4 changes: 0 additions & 4 deletions vsts/node-nightly-df.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ phases:
IOT_PROVISIONING_ROOT_CERT: $(LINUX-IOT-PROVISIONING-ROOT-CERT)
IOT_PROVISIONING_ROOT_CERT_KEY: $(LINUX-IOT-PROVISIONING-ROOT-CERT-KEY)
IOT_PROVISIONING_SERVICE_CONNECTION_STRING: $(LINUX-IOT-PROVISIONING-SERVICE-CONNECTION-STRING)
DPS_CONN_STRING_INVALID_CERT: $(DPS-CONN-STRING-INVALID-CERT)
DPS_GLOBAL_DEVICE_ENDPOINT_INVALID_CERT: $(DPS-GLOBAL-DEVICE-ENDPOINT-INVALID-CERT)
IOTHUB_CONN_STRING_INVALID_CERT: $(IOTHUB-CONN-STRING-INVALID-CERT)
IOTHUB_DEVICE_CONN_STRING_INVALID_CERT: $(IOTHUB-DEVICE-CONN-STRING-INVALID-CERT)

- task: PublishTestResults@2
displayName: 'Publish Test Results | Mocha'
Expand Down

0 comments on commit 1148eac

Please sign in to comment.