-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add sdk configuration changes template (#31842)
* first try * templates added * update template * Update .github/PULL_REQUEST_TEMPLATE/sdk_configuration_template.md Co-authored-by: Ben Broderick Phillips <ben@benbp.net> --------- Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
- Loading branch information
Showing
2 changed files
with
27 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
.github/PULL_REQUEST_TEMPLATE/sdk_configuration_template.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# SDK configuration pull request | ||
|
||
## Purpose of this PR | ||
|
||
- [ ] Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review. | ||
|
||
## Due diligence checklist | ||
|
||
To merge this PR, you **must** go through the following checklist and confirm you understood | ||
and followed the instructions by checking all the boxes: | ||
|
||
- [ ] I confirm this PR is modifying only SDK configurations, and not API related specifications. | ||
- [ ] I have reviewed and used the respective `tspconfig.yaml` templates: | ||
- [ARM tspconfig template](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.Management/tspconfig.yaml) | ||
- [Data plane tspconfig template](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml) | ||
|
||
## Getting help | ||
|
||
- First, carefully read through this PR description, from top to bottom. Fill out the `Purpose of this PR` and `Due diligence checklist`. | ||
- If you don't have permissions to remove or add labels to the PR, request `write access` per [aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories](https://aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories) | ||
- To understand what you must do next to merge this PR, see the `Next Steps to Merge` comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. | ||
- For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix. | ||
- If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. | ||
This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes. | ||
- If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR. |