Skip to content

Commit

Permalink
Microsft.Web 2023-12-01: Add int32 format to all number types in the …
Browse files Browse the repository at this point in the history
…scaleAndConcurrency section of the functionAppConfig (#30050)

* Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907)

* Set format to int32 for all number types in the functionAppConfig

* Update types to integer.

---------

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>

* Update types to integer and set format to int32 for all number types in the functionAppConfig

---------

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
  • Loading branch information
Francisco-Gamino and naveedaz authored Aug 15, 2024
1 parent 395e921 commit 9ce2bd0
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3677,7 +3677,8 @@
"description": "Either a function group or a function name is required. For additional information see https://aka.ms/flexconsumption/alwaysready."
},
"instanceCount": {
"type": "number",
"type": "integer",
"format": "int32",
"description": "Sets the number of 'Always Ready' instances for a given function group or a specific function. For additional information see https://aka.ms/flexconsumption/alwaysready."
}
}
Expand All @@ -3695,11 +3696,13 @@
},
"maximumInstanceCount": {
"description": "The maximum number of instances for the function app.",
"type": "number"
"type": "integer",
"format": "int32"
},
"instanceMemoryMB": {
"description": "Set the amount of memory allocated to each instance of the function app in MB. CPU and network bandwidth are allocated proportionally.",
"type": "number"
"type": "integer",
"format": "int32"
},
"triggers": {
"type": "object",
Expand All @@ -3710,7 +3713,8 @@
"description": "Scale and concurrency settings for the HTTP trigger.",
"properties": {
"perInstanceConcurrency": {
"type": "number",
"type": "integer",
"format": "int32",
"description": "The maximum number of concurrent HTTP trigger invocations per instance."
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3710,7 +3710,8 @@
"description": "Either a function group or a function name is required. For additional information see https://aka.ms/flexconsumption/alwaysready."
},
"instanceCount": {
"type": "number",
"type": "integer",
"format": "int32",
"description": "Sets the number of 'Always Ready' instances for a given function group or a specific function. For additional information see https://aka.ms/flexconsumption/alwaysready."
}
}
Expand All @@ -3728,11 +3729,13 @@
},
"maximumInstanceCount": {
"description": "The maximum number of instances for the function app.",
"type": "number"
"type": "integer",
"format": "int32"
},
"instanceMemoryMB": {
"description": "Set the amount of memory allocated to each instance of the function app in MB. CPU and network bandwidth are allocated proportionally.",
"type": "number"
"type": "integer",
"format": "int32"
},
"triggers": {
"type": "object",
Expand All @@ -3743,7 +3746,8 @@
"description": "Scale and concurrency settings for the HTTP trigger.",
"properties": {
"perInstanceConcurrency": {
"type": "number",
"type": "integer",
"format": "int32",
"description": "The maximum number of concurrent HTTP trigger invocations per instance."
}
}
Expand Down
4 changes: 4 additions & 0 deletions specification/web/resource-manager/sdk-suppressions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,7 @@ suppressions:
- Function `*StaticSitesClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
- Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnectionSlot` parameter(s) have been changed from `(context.Context, string, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)` to `(context.Context, string, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)`
- Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
- Type of `FunctionsAlwaysReadyConfig.InstanceCount` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrency.InstanceMemoryMB` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrency.MaximumInstanceCount` has been changed from `*float32` to `*int32`
- Type of `FunctionsScaleAndConcurrencyTriggersHTTP.PerInstanceConcurrency` has been changed from `*float32` to `*int32`

0 comments on commit 9ce2bd0

Please sign in to comment.