[TextAnalytics] [Conversations] Update method naming in client.tsp #29622

bidisha-c · 2024-06-27T21:17:43Z

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

openapi-pipeline-app · 2024-06-27T21:17:48Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-06-27T21:17:48Z

PR validation pipeline restarted successfully. This comment will be populated with the 'Swagger Validation Report'

openapi-pipeline-app · 2024-06-27T21:17:49Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-net-track2 failed [Detail]

FAQ

❌Failed in generating from da03f839d6a61380e31bcd801581be54696b1ce1. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:910
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  910 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build project. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:910
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  910 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build project. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:144
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  144 |              GeneratePackage `
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |              ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:144
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  144 |              GeneratePackage `
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |              ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build project. exit code: False

❌Azure.AI.Language.Conversations [Preview SDK Changes]
```
info	[Changelog]
```
❌Azure.AI.TextAnalytics [Preview SDK Changes]
```
info	[Changelog]
```
️✔️Azure.AI.Language.AnalyzeText [Preview SDK Changes]
```
info	[Changelog]
```
❌Azure.AI.Language.Conversations [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

FAQ

⚠️Warning in generating from da03f839d6a61380e31bcd801581be54696b1ce1. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.2
cmderr	[automation_init.sh] npm notice
warn		Warning: azure-sdk-for-python cannot be found in specification/cognitiveservices/data-plane/Language/readme.md. This SDK will be skipped from SDK generation. Please add the right config to the readme file according to this guidance https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/code-gen/configure-go-sdk.md#swagger-to-sdk.
warn		Warning: cannot find emitter config for azure-sdk-for-python in tspconfig.yaml for typespec project specification/cognitiveservices/Language.AnalyzeText/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
warn		Warning: cannot find emitter config for azure-sdk-for-python in tspconfig.yaml for typespec project specification/cognitiveservices/Language.Conversations/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
warn	Warning: No file changes detected after the generation. Please refer to the generation errors to understand the reasons.
warn	Warning: No package detected after generation. Please refer to the above logs to understand why the package hasn't been generated.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-06-27T21:17:49Z

Generated ApiView

Language	Package Name	ApiView Link
Swagger	Language	https://apiview.dev/Assemblies/Review/d940fcb06e874adebca52d9bf9e40221?revisionId=506ce900fbf9420a8bee7dca01d6f320
TypeSpec	Language.AnalyzeText	https://apiview.dev/Assemblies/Review/d3e90313604e49b3a006c2ae96247ff3?revisionId=124cefbce8be4b0b9f4e838103b6e9b1
TypeSpec	Language.Conversations	https://apiview.dev/Assemblies/Review/8c72372fd7bc4871a639327bdfb7c07f?revisionId=9f5cd5a7d0de40ee96f15c91ff1de6ae

specification/cognitiveservices/data-plane/Language/stable/2023-04-01/analyzetext.json

specification/cognitiveservices/Language.AnalyzeText/models/common.models.tsp

specification/cognitiveservices/Language.AnalyzeText/models/summarization.tsp

catalinaperalta · 2024-07-18T23:02:03Z

Looks like the Model Validation step is reporting some issues in the examples due to the changes in this PR. Please resolve before we can merge.
https://github.com/Azure/azure-rest-api-specs/pull/29622/checks?check_run_id=27636351801

…/azure-rest-api-specs into bidishac/client-naming

…29622) * [TA] [Conversations] Update naming in client.tsp * enable model-namespaces * fix tsv errors * small change * Add prediction base * one more rename * another rename * some missed ones * small change * rename * ta change * Add HC namespace * casing + remove hc folder * remove sentenceSentiment override * another one * update * renames * disable protocol methods * tsp compile * Update naming conventions * Add AAD auth * renames * change * update TextAnalytics TSP for sdk * rename for Conversations SDK * remove duplicates * update config * Removed duplicates in naming * fix client names and operation names * update * Fix the casing of the result * fix Text SDK errors * fix AnalyzeTextLROResultsKind access level * bugfix AbstractiveSummarizationLROTask parameters to be optional * typo * align * update Text client name to TextAnalysis * Fix the examples * Add tsv compile * Missed file * rename issue * Fix input polymorphism * Update clientName * remove model namespace * Backcompat * small update * update client --------- Co-authored-by: Bidisha Chakraborty <bidishac@microsoft.com> Co-authored-by: Quentin Robinson <32183739+quentinRobinson@users.noreply.github.com>

Bidisha Chakraborty added 2 commits June 27, 2024 13:58

[TA] [Conversations] Update naming in client.tsp

840df97

enable model-namespaces

8b877df

bidisha-c requested a review from yangyuan as a code owner June 27, 2024 21:17

AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Jun 27, 2024

azure-sdk mentioned this pull request Jun 27, 2024

[AutoPR Azure.AI.Language.Conversations] [TextAnalytics] [Conversations] Update method naming in client.tsp azure-sdk/azure-sdk-for-net#8341

Closed

Bidisha Chakraborty added 10 commits June 28, 2024 14:53

fix tsv errors

ec4b777

small change

014a436

Add prediction base

96b0f2a

one more rename

28ee478

another rename

841ba59

some missed ones

08fe4a8

small change

8fe8017

rename

59f3e2c

ta change

4f6d750

Add HC namespace

fa52df6

bidisha-c requested review from annatisch, heaths, deyaaeldeen, kristapratico, mssfang, joseharriaga, minhanh-phan and a team as code owners June 29, 2024 01:21

bidisha-c requested review from scgbear and mario-guerra and removed request for a team June 29, 2024 01:21

quentinRobinson and others added 2 commits July 18, 2024 13:42

update Text client name to TextAnalysis

6fad1db

Merge branch 'main' into bidishac/client-naming

f4ca504

johanste approved these changes Jul 18, 2024

View reviewed changes

johanste added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Jul 18, 2024

AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jul 18, 2024

catalinaperalta reviewed Jul 18, 2024

View reviewed changes

specification/cognitiveservices/data-plane/Language/stable/2023-04-01/analyzetext.json Show resolved Hide resolved

catalinaperalta reviewed Jul 18, 2024

View reviewed changes

specification/cognitiveservices/Language.AnalyzeText/models/common.models.tsp Show resolved Hide resolved

catalinaperalta reviewed Jul 18, 2024

View reviewed changes

specification/cognitiveservices/Language.AnalyzeText/models/common.models.tsp Show resolved Hide resolved

catalinaperalta reviewed Jul 18, 2024

View reviewed changes

specification/cognitiveservices/Language.AnalyzeText/models/summarization.tsp Show resolved Hide resolved

catalinaperalta approved these changes Jul 18, 2024

View reviewed changes

bidisha-c and others added 9 commits July 19, 2024 10:57

Merge branch 'main' into bidishac/client-naming

e4921e2

Fix the examples

44726fc

Merge branch 'bidishac/client-naming' of https://github.com/bidisha-c…

c84d891

…/azure-rest-api-specs into bidishac/client-naming

Add tsv compile

9014f05

Missed file

d8069c8

rename issue

57ad557

Merge branch 'main' into bidishac/client-naming

33f0e78

Fix input polymorphism

24eb341

Update clientName

1a2b0fb

bidisha-c added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jul 22, 2024

quentinRobinson and others added 6 commits July 24, 2024 15:29

remove model namespace

b6d92ff

Backcompat

f072941

Merge branch 'bidishac/client-naming' of https://github.com/bidisha-c…

4a8f668

…/azure-rest-api-specs into bidishac/client-naming

small update

c463ca9

update client

641e095

Merge branch 'main' into bidishac/client-naming

c2d9d8f

catalinaperalta merged commit 7660d4c into Azure:main Jul 29, 2024
28 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TextAnalytics] [Conversations] Update method naming in client.tsp #29622

[TextAnalytics] [Conversations] Update method naming in client.tsp #29622

bidisha-c commented Jun 27, 2024

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

catalinaperalta commented Jul 18, 2024

[TextAnalytics] [Conversations] Update method naming in client.tsp #29622

[TextAnalytics] [Conversations] Update method naming in client.tsp #29622

Conversation

bidisha-c commented Jun 27, 2024

Choose a PR Template

openapi-pipeline-app bot commented Jun 27, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Jun 27, 2024 • edited Loading

openapi-pipeline-app bot commented Jun 27, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented Jun 27, 2024 • edited Loading

Generated ApiView

catalinaperalta commented Jul 18, 2024

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading

openapi-pipeline-app bot commented Jun 27, 2024 •

edited

Loading