Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding vnv, ipam and sec admin 2024-01-01 preview #29924

Closed
wants to merge 4 commits into from

forgot to add the right package

0f025c6
Select commit
Loading
Failed to load commit list.
Closed

adding vnv, ipam and sec admin 2024-01-01 preview #29924

forgot to add the right package
0f025c6
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff failed Jul 26, 2024 in 18m 10s

Swagger LintDiff failed

LintDiff: 48 Errors, 26 Warnings
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.3) new version base version
package-2024-01-preview package-2024-01-preview(0f025c6) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'IpamPoolList' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/ipAddressManager.json#L765		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'IpamPoolList' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/ipAddressManager.json#L765		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'StaticCidrList' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/ipAddressManager.json#L1044		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'StaticCidrList' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/ipAddressManager.json#L1044		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'ReachabilityAnalysisIntentListResult' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkVerifier.json#L1038		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'ReachabilityAnalysisIntentListResult' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkVerifier.json#L1038		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'ReachabilityAnalysisRunListResult' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkVerifier.json#L1110		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'ReachabilityAnalysisRunListResult' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkVerifier.json#L1110		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'VerifierWorkspaceListResult' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkVerifier.json#L1182		 RPC-Put-V1-06
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'VerifierWorkspaceListResult' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkVerifier.json#L1182		 RPC-Put-V1-06
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.Network/preview/2024-01-01-preview/ipAddressManager.json#L8		 RPC-Get-V1-11


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L38
❌ MissingTypeObject The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L55
❌ MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L83
❌ MissingTypeObject The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L93
❌ MissingTypeObject The schema 'AzureAsyncOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L118
❌ MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L140
❌ MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L198
❌ MissingTypeObject The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L208
❌ MissingTypeObject The schema 'ManagedServiceIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L273
❌ AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L301
❌ ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L321
❌ MissingTypeObject The schema 'ExtendedLocation' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L395
❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L410
❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L417
❌ XmsParameterLocation The parameter 'ApiVersionVmssParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L424
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L121
❌ PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L218
❌ SystemDataDefinitionsCommonTypes System data references must utilize common types.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L439
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'NetworkManagerListResult' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L449
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'NetworkManagerListResult' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L449
❌ ResourceNameRestriction The resource name parameter 'configurationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L87
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L177
❌ ResourceNameRestriction The resource name parameter 'configurationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L222
❌ ResourceNameRestriction The resource name parameter 'configurationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L276
❌ ResourceNameRestriction The resource name parameter 'ruleCollectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L276
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L366
❌ ResourceNameRestriction The resource name parameter 'configurationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L411
❌ ResourceNameRestriction The resource name parameter 'ruleCollectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L411
❌ ResourceNameRestriction The resource name parameter 'configurationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L468
❌ ResourceNameRestriction The resource name parameter 'ruleCollectionName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L468
❌ ResourceNameRestriction The resource name parameter 'ruleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L468
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L567
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'SecurityAdminConfigurationListResult' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L667
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'SecurityAdminConfigurationListResult' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L667
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'AdminRuleListResult' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L684
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'AdminRuleListResult' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L684
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'AdminRuleCollectionListResult' has extra properties ['value'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L701
❌ BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'AdminRuleCollectionListResult' has extra properties ['nextLink'].
Location: Microsoft.Network/preview/2024-01-01-preview/networkManagerSecurityAdminConfiguration.json#L701
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L69
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L108
⚠️ LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L156
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L411
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L418
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
Location: Microsoft.Network/preview/2024-01-01-preview/network.json#L425
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L84
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L126
⚠️ PatchInOperationName 'PATCH' operation 'NetworkManagers_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L169
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L171
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'commit' in:'NetworkManagerCommits_Post'. Consider updating the operationId
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L222
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/preview/2024-01-01-preview/networkManager.json#L224
View more details on openapi-pipeline-app