Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @typespec/compiler version to next #30001

Closed
wants to merge 1 commit into from

Conversation

v-jiaodi
Copy link
Member

Description:
Upgrade @typespec/compiler version to next causing LoadTestService generation failure

repro step:

  1. Update package.json as follow:
{
  "name": "azure-rest-api-specs",
  "devDependencies": {
    "@azure-tools/typespec-apiview": "0.4.9",
    "@azure-tools/typespec-autorest": "0.45.0-dev.3",
    "@azure-tools/typespec-azure-core": "0.45.0-dev.3",
    "@azure-tools/typespec-azure-portal-core": "0.44.0",
    "@azure-tools/typespec-azure-resource-manager": "0.45.0-dev.4",
    "@azure-tools/typespec-azure-rulesets": "0.45.0-dev.1",
    "@azure-tools/typespec-client-generator-cli": "0.9.3",
    "@azure-tools/typespec-client-generator-core": "0.45.0-dev.5",
    "@azure/avocado": "^0.8.4",
    "@typespec/compiler": "0.59.0-dev.7",
    "@typespec/http": "0.59.0-dev.4",
    "@typespec/openapi": "0.59.0-dev.1",
    "@typespec/openapi3": "0.58.0",
    "@typespec/rest": "0.59.0-dev.1",
    "@typespec/versioning": "0.59.0-dev.3",
    "azure-rest-api-specs-eng-tools": "file:eng/tools",
    "oav": "^3.3.7",
    "prettier": "~3.2.5",
    "typescript": "~5.4.5"
  },
  "private": true
}

  1. Run npm i -g @typespec/compiler and npm i
  2. Enter the specification/loadtestservice/LoadTestService folder, and run npx tsp compile client.tsp

Error log:
image

Copy link

openapi-pipeline-app bot commented Jul 29, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named TypeSpec Requirement (resource-manager) has failed. TypeSpec usage is required for all new (aka "greenfield") services. The automation detected this pull request adds at least one new service that is violating this requirement. For information on converting from OpenAPI specs to TypeSpec specs or on data-plane (DP) policies, refer to aka.ms/azsdk/typespec. If you have general questions on resource provider (RP) policies, refer to aka.ms/rphelp
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Important checks have failed. As of today they are not blocking this PR, but in near future they will.
Addressing the following failures is highly recommended:
  • ⚠️ The check named TypeSpec Requirement (data-plane) has failed. TypeSpec usage is required for all new (greenfield) services. This is currently enforced as a warning for data-plane specs, but will be made a blocking error in the near future. For information on converting from OpenAPI specs to TypeSpec specs or on data-plane (DP) policies, refer to aka.ms/azsdk/typespec. If you have general questions on resource provider (RP) policies, refer to aka.ms/rphelp

Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@timotheeguerin
Copy link
Member

Fix in this pr #30005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants