Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release web 2024 04 01 #30415

Merged
merged 12 commits into from
Sep 26, 2024
Merged

Release web 2024 04 01 #30415

merged 12 commits into from
Sep 26, 2024

Conversation

naveedaz
Copy link
Contributor

@naveedaz naveedaz commented Sep 3, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

naveedaz and others added 12 commits May 21, 2024 08:17
* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Fix RP merge issue

* Fix prettier failute

* Fix spellcheck for sitecontainers

* Fix prettier check failures

* Fix ALL prettier check failures
* Add LeastRequestsWithTieBreaker

* Change to target 2024-04-01

---------

Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
…#29350)

* Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226)

* Rename enum to functionsDeploymentStorageType

* Update enum name to camel case

* Update enum names to camel case

* Port changes to 2024-04-01 API version

* Rename storageType to FunctionsDeploymentStorageType
* Update enum name's to use amelcase casing

---------

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
#29354)

* Add SKU property to site. Add description for supported values of kind property on app

* Fix typo

* Fix prettier
* Adding parameter to Website Instance Info obj

* Prettier

---------

Co-authored-by: Rohini Sharma <rohinisharma@microsoft.com>
Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
* [DNL] Add AutoGeneratedDomainNameLabelScope to Websites

* fix casing

* fix prettier
Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
* Add updatemachinekey api

* fix json formatting

* Change api version

* Add machinekey to allowed words

* action verb at end of address

* Change post address to conform to arm

---------

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
* [DNL] Add AutoGeneratedDomainNameLabelScope to Websites

* Minor comment update
* Add IP Mode to Websites

* Target 2024-04-01

* Fix linter

---------

Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
…scaleAndConcurrency section of the functionAppConfig (#30050)

* Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907)

* Set format to int32 for all number types in the functionAppConfig

* Update types to integer.

---------

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>

* Update types to integer and set format to int32 for all number types in the functionAppConfig

---------

Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>
Co-authored-by: Naveed Aziz <naveeda@microsoft.com>
Copy link

openapi-pipeline-app bot commented Sep 3, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@naveedaz
Copy link
Contributor Author

naveedaz commented Sep 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@naveedaz naveedaz requested a review from gary-x-li September 9, 2024 23:31
@naveedaz
Copy link
Contributor Author

naveedaz commented Sep 9, 2024

@msyyc , @tadelesh , @gary-x-li ,
Please review but not merge yet (waiting on ARM manifest rollout). This PR contains only PRs already reviewed by ARM

#28952
#29128
#29226
#29354
#29333
#29649
#29904
#29730
#30047
#29089
#30050
#29907
#30067

@gary-x-li gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 9, 2024
@msyyc
Copy link
Member

msyyc commented Sep 11, 2024

@naveedaz I am Python SDK owner and this PR is not marked with SDK breaking change label so you don't need my approval.

@gary-x-li gary-x-li mentioned this pull request Sep 12, 2024
8 tasks
@naveedaz naveedaz added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 25, 2024
@naveedaz naveedaz self-assigned this Sep 25, 2024
@naveedaz naveedaz enabled auto-merge (squash) September 25, 2024 22:58
@naveedaz naveedaz merged commit b5d78da into main Sep 26, 2024
27 of 31 checks passed
@naveedaz naveedaz deleted the release-web-2024-04-01 branch September 26, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants