Restructure KubernetesConfiguration directories to a suite of services #31523
+9,141
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
AzureRestAPISpecReview
added
ARMReview
new-api-version
resource-manager
SuppressionReviewRequired
WaitForARMFeedback
This was referenced Nov 13, 2024
dipti-pai
force-pushed
the
suite-of-services
branch
from
c558dd7 to
0a823db
Compare
dipti-pai
force-pushed
the
suite-of-services
branch
from
0a823db to
38a10af
Compare
|
@dipti-pai what is the base version i can use for comparing the files? why there are different versions for each service? |
|
see also the errors from the required modelvalidation, semanticvalidation, lintdiff checks |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
/azp run |
tadelesh
reviewed
Jan 15, 2025
...configuration/resource-manager/Microsoft.KubernetesConfiguration/extensionTypes/readme.go.md
Outdated
Show resolved
Hide resolved
...configuration/resource-manager/Microsoft.KubernetesConfiguration/extensionTypes/readme.go.md
Outdated
Show resolved
Hide resolved
...etesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/extensions/readme.go.md
Outdated
Show resolved
Hide resolved
...etesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/extensions/readme.go.md
Outdated
Show resolved
Hide resolved
...iguration/resource-manager/Microsoft.KubernetesConfiguration/fluxConfigurations/readme.go.md
Outdated
Show resolved
Hide resolved
...iguration/resource-manager/Microsoft.KubernetesConfiguration/fluxConfigurations/readme.go.md
Outdated
Show resolved
Hide resolved
...figuration/resource-manager/Microsoft.KubernetesConfiguration/privateLinkScopes/readme.go.md
Outdated
Show resolved
Hide resolved
...figuration/resource-manager/Microsoft.KubernetesConfiguration/privateLinkScopes/readme.go.md
Outdated
Show resolved
Hide resolved
…ft.KubernetesConfiguration/extensionTypes/readme.go.md removing track config for extensionTypes Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
…ft.KubernetesConfiguration/extensionTypes/readme.go.md Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
…ft.KubernetesConfiguration/extensions/readme.go.md removing track config for extensions Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
…ft.KubernetesConfiguration/extensions/readme.go.md Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
…ft.KubernetesConfiguration/fluxConfigurations/readme.go.md removing track config for fluxConfigurations Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
…ft.KubernetesConfiguration/fluxConfigurations/readme.go.md Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
…ft.KubernetesConfiguration/privateLinkScopes/readme.go.md removing track config for pls Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
…ft.KubernetesConfiguration/privateLinkScopes/readme.go.md Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
@tadelesh Thank you, I have committed your suggestions. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dipti-pai could you remove the top level kubernateconfigurations readme.typescript.md file specification/kubernetesconfiguration/resource-manager/readme.typescript.md if they have been splitted into several packages? It will resolve JS SDK generation failure. |
this should not be the root cause, I create a new pr base on this and it passed the JS automation here https://github.com/Azure/azure-rest-api-specs/pull/32207/checks?check_run_id=35760656197 |
bavneetsingh16
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the Kubernetes Configuration Services into a service group with 5 services. The swaggers for each service group has no new changes except FluxConfiguration Service which includes addition of a new provider field. ARM changes were reviewed by ARM team and signed off in PR #30956 . The service group restructuring has been discussed with the Azure Breaking Changes Board.
These are the 5 services -
Flux Configuration Service
-- new API version: stable 2024-11-01 version
-- base version specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/preview/2024-04-01-preview/fluxconfiguration.json
Extensions Service
-- new API version: stable 2024-11-01
-- base API version: specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2023-05-01
Extension Types Service
-- new API version: preview 2024-11-01-preview
-- base API version: specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/preview/2023-05-01-preview/extensionTypes.json
Private Link Scopes Service
-- new API version: preview 2024-11-01-preview
-- base API version: specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/preview/2022-04-02-preview/privateLinkScopes.json
Operations Service
-- new API version: stable 2024-11-01
-- base API version: specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2023-05-01/operations.json
For new reviewers, a lot of the discussions in this PR is regarding the Operations service. Summarizing the conclusion after discussion with the ARM team and Breaking changes board team -
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.