-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update description for metric alert API to clarify scope limitations #32223
Open
shirelch1
wants to merge
4
commits into
main
Choose a base branch
from
shirelch1/update_scopes_documentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
github-actions
bot
added
the
brownfield
Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec.
label
Jan 19, 2025
API change check APIView has identified API level changes in this PR and created following API reviews. |
microsoft-github-policy-service
bot
added
the
Monitor
Monitor, Monitor Ingestion, Monitor Query
label
Jan 19, 2025
This was referenced Jan 19, 2025
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
RPaaS
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Jan 19, 2025
shirelch1
added
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
Versioning-Approved-BugFix
https://github.com/Azure/azure-sdk-tools/issues/6374
labels
Jan 19, 2025
noneumar
approved these changes
Jan 19, 2025
AzureRestAPISpecReview
removed
the
Versioning-Approved-BugFix
https://github.com/Azure/azure-sdk-tools/issues/6374
label
Jan 22, 2025
shirelch1
added
the
BreakingChange-Approved-BugFix
Changes are to correct the REST API definition to correctly describe service behavior
label
Jan 22, 2025
AzureRestAPISpecReview
removed
the
BreakingChange-Approved-BugFix
Changes are to correct the REST API definition to correctly describe service behavior
label
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
brownfield
Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec.
Monitor
Monitor, Monitor Ingestion, Monitor Query
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
RPaaS
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.