Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed datamap endpoint from string to url #32276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parthmiglani-microsoft
Copy link

@parthmiglani-microsoft parthmiglani-microsoft commented Jan 22, 2025

SDK configuration pull request

Purpose of this PR

Changing the endpoint for datamap from string to url, since tests are failing for sdk after fixing typing errors due to pyright version upgrade.
Ref: Azure/azure-sdk-for-python#39324 (review)

  • Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Getting help

  • First, carefully read through this PR description, from top to bottom. Fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Jan 22, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jan 22, 2025

Generated ApiView

Language Package Name ApiView Link
JavaScript @azure-rest/purview-datamap https://apiview.dev/Assemblies/Review/277e1d1cf90e4fad82c72870fb2b6635?revisionId=b41d3aec3e4946c0958bc248a8246475
Java azure-analytics-purview-datamap There is no API change compared with the previous version
.Net Azure.Analytics.Purview.DataMap There is no API change compared with the previous version
Python azure-purview-datamap https://apiview.dev/Assemblies/Review/88bce871a7c14e5ea77249c7ca663131?revisionId=865a437e883a40b6a2656bae467212be

@catalinaperalta
Copy link
Member

catalinaperalta commented Jan 22, 2025

@parthmiglani-microsoft you need to regenerate the openapi file before merging this pr in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Purview TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants