Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support serializing received message to/from AMQP bytes #33682

Merged
merged 15 commits into from
Feb 2, 2023
Merged

Support serializing received message to/from AMQP bytes #33682

merged 15 commits into from
Feb 2, 2023

Conversation

JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Jan 25, 2023 •
edited
Loading

This lays the groundwork for binding to ServiceBusReceivedMessage in the .NET isolated functions worker.

JoshLove-msft
JoshLove-msft commented Jan 25, 2023
View reviewed changes
NuGet.Config Outdated Show resolved Hide resolved
@JoshLove-msft
Copy link
Member Author

/cc @liliankasem

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 25, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.ServiceBus

@JoshLove-msft JoshLove-msft mentioned this pull request Jan 26, 2023
Open
@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@JoshLove-msft JoshLove-msft enabled auto-merge (squash) February 2, 2023 17:46
auto-merge was automatically disabled February 2, 2023 20:14

Pull request was closed

@JoshLove-msft JoshLove-msft reopened this Feb 2, 2023
@JoshLove-msft
Copy link
Member Author

/check-enforcer evaluate

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Check Enforcer evaluate was requested, but no Azure Pipelines or Github Actions have been triggered for the changed files.

If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run /check-enforcer override.

For help using check enforcer, see https://aka.ms/azsdk/checkenforcer

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@JoshLove-msft
Copy link
Member Author

/check-enforcer reset

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Check Enforcer evaluate was requested, but no Azure Pipelines or Github Actions have been triggered for the changed files.

If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run /check-enforcer override.

For help using check enforcer, see https://aka.ms/azsdk/checkenforcer

@JoshLove-msft JoshLove-msft enabled auto-merge (squash) February 2, 2023 20:28
@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

amnguye
amnguye approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@amnguye amnguye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Storage Webjobs Extension SDK

@amnguye amnguye mentioned this pull request Feb 2, 2023
Merged
7 tasks
@JoshLove-msft
Copy link
Member Author

LGTM for the Storage Webjobs Extension SDK

Thanks - I ended up reverting these as we are leaving the dependency at 3.0.35 which doesn't have the new constructor.

@JoshLove-msft JoshLove-msft merged commit 269268d into Azure:main Feb 2, 2023
@liliankasem liliankasem mentioned this pull request Feb 2, 2023
Closed
2 tasks
@JohnCarmichael3000
Copy link

"This lays the groundwork for binding to ServiceBusReceivedMessage in the .NET isolated functions worker."

Newbie question: will this include ServiceBusMessageActions as well?

@surgupta-msft surgupta-msft mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina left review comments

@liliankasem liliankasem liliankasem left review comments

@christothes christothes christothes left review comments

@jsquire jsquire jsquire approved these changes

@danielmarbach danielmarbach danielmarbach left review comments

@amnguye amnguye amnguye approved these changes

@hallipr hallipr Awaiting requested review from hallipr

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

@tg-msft tg-msft Awaiting requested review from tg-msft

@m-redding m-redding Awaiting requested review from m-redding m-redding is a code owner

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@fabiocav fabiocav Awaiting requested review from fabiocav

@mathewc mathewc Awaiting requested review from mathewc

Assignees
No one assigned
Labels
Azure.Core Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@JoshLove-msft @azure-sdk @JohnCarmichael3000 @danielmarbach @jsquire @christothes @liliankasem @weshaggard @KrzysztofCwalina @amnguye