Make logging levels case insensitive

Added '.lower()' to string being parsed for logging.
Azure · Aug 20, 2024 · 666fb02 · 666fb02
1 parent 5f6be69
commit 666fb02
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py b/tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
@@ -2762,7 +2762,7 @@ def check_for_logging(self, node):
         matches = [".warning", ".error"]
         for j in node:
             if isinstance(j, astroid.Expr):
-                expression = j.as_string()
+                expression = j.as_string().lower()
                 if any(x in expression for x in matches):
                     self.add_message(
                         msgid=f"do-not-log-raised-errors",

diff --git a/tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py b/tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py
@@ -4844,7 +4844,7 @@ def test_error_level_not_logged(self):
         try: #@
             add = 1 + 2
         except Exception as e:
-            logger.error(str(e)) #@
+            logger.ERROR(str(e)) #@
             raise
         '''
                                               )