fix

Azure · Jun 17, 2024 · 7785995 · 7785995
1 parent 7a25304
commit 7785995
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/tools/js-sdk-release-tools/package.json b/tools/js-sdk-release-tools/package.json
@@ -9,7 +9,8 @@
     "build": "rimraf dist && tsc -p .",
     "prepack": "npm run build",
     "test": "vitest --run",
-    "test:watch": "vitest"
+    "test:watch": "vitest",
+    "test:ci": "node dist/changelogToolCli.js src/test/testCases/ci/arm-networkanalytics"
   },
   "bin": {
     "changelog-tool": "./dist/changelogToolCli.js",

diff --git a/tools/js-sdk-release-tools/src/changelog/changelogGenerator.ts b/tools/js-sdk-release-tools/src/changelog/changelogGenerator.ts
@@ -199,11 +199,11 @@ const findAddedOperation = (metaDataOld: TSExportedMetaData, metaDataNew: TSExpo
     Object.keys(metaDataNew.operationInterface).forEach(newOperationGroup => {
         const oldOperationGroup = oldSdkType === newSdkType ? newOperationGroup : newToOldMap[newOperationGroup];
         const newInterfaceMethodNames = getAllMethodNameInInterface(metaDataNew.operationInterface[newOperationGroup]);
-        const oldInterfaceNameMethods = getAllMethodNameInInterface(metaDataOld.operationInterface[oldOperationGroup]);
+        const oldInterfaceMethodNames = getAllMethodNameInInterface(metaDataOld.operationInterface[oldOperationGroup]);
         newInterfaceMethodNames
-            .filter(newOpName => !oldInterfaceNameMethods.includes(newOpName))
+            .filter(newOpName => !oldInterfaceMethodNames.includes(newOpName))
             .forEach(newOpName => { addOperation.push('Added operation ' + newOperationGroup + '.' + newOpName); });
-        return true;
+        return;
     });
     return addOperation;
 };
@@ -475,9 +475,9 @@ const findRemovedOperation = (metaDataOld: TSExportedMetaData, metaDataNew: TSEx
 
     Object.keys(metaDataOld.operationInterface).forEach(oldOperationGroup => {
         const newOperationGroup = oldSdkType === newSdkType ? oldOperationGroup : oldToNew[oldOperationGroup];
-        const newInterfaceMethodNames = getAllMethodNameInInterface(metaDataOld.operationInterface[oldOperationGroup]);
-        const oldInterfaceNameMethods = getAllMethodNameInInterface(metaDataNew.operationInterface[newOperationGroup]);
-        oldInterfaceNameMethods
+        const newInterfaceMethodNames = getAllMethodNameInInterface(metaDataNew.operationInterface[newOperationGroup]);
+        const oldInterfaceMethodNames = getAllMethodNameInInterface(metaDataOld.operationInterface[oldOperationGroup]);
+        oldInterfaceMethodNames
             .filter(oldOpName => !newInterfaceMethodNames.includes(oldOpName))
             .forEach(oldOpName => { removedOperation.push('Removed operation ' + oldOperationGroup + '.' + oldOpName); });
         return true;