Don't log errors that we end up raising #22557 #8819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new rule for this issue to the pylint_guidelines_checker file. Added corresponding tests to the test_pylint_custom_plugins file
Added two more tests to check for multiple exception blocks
Changed 'warning' to '.warning' etc. Help avoid any false positives e.g. 'print("error")' will now not trigger Pylint
Merge branch 'main' into dont-log-errors-end-up-raising
Also added another test to test_pylint_custom_plugins.py for 'warning' level.
|
@microsoft-github-policy-service agree |
annatisch
reviewed
Aug 11, 2024
tools/pylint-extensions/azure-pylint-guidelines-checker/README.md
Outdated
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py
Outdated
Show resolved
Hide resolved
Also rename checker to "do-not-log-raised-errors"
Added '.lower()' to string being parsed for logging.
|
/azp run tools - azure-pylint-guidelines-checker - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Sep 1, 2024
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Outdated
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Outdated
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Outdated
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py
Show resolved
Hide resolved
…_guidelines_checker.py Co-authored-by: Anna Tisch <antisch@microsoft.com>
Also added relevant tests
The output of the Pylint testing against the SDKs is below. This was before the changes I have just made. Will run tests again later :). All of them are true positives. |
Refactored function and removed 'isInstance Astroid.For' and associated tests
annatisch
approved these changes
Sep 3, 2024
|
Output from re-testing against the SDKs after changes made yesterday. Looks good, all true positives :) |
l0lawrence
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Azure/azure-sdk-for-python#22557
Checks that errors raised in exception blocks aren't also logged at '
warning' and 'error' levels.