Avoid adding the same package twice, use TrimStart instead of substring #8912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following pipelines have been queued for testing: |
weshaggard
approved these changes
Sep 3, 2024
This was referenced Sep 3, 2024
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Sep 3, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8912 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-PrPkgProperties was adding a package to $packagesWithChanges for every matched file in the pr diff. To prevent duplicate entries, we break the for loop on the first matched file.
If the input path didn't start with $RepoRoot, the key function
<path>.Replace($RepoRoot, "").SubString(1)was removing the first character of a relative path.sdk/some/package=>dk/some/package.TrimStart('\/')will remove the starting path separator only if it exists.