Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python APIView] tree token parser conversion #9146

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from
Draft

[Python APIView] tree token parser conversion #9146

wants to merge 65 commits into from

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Oct 11, 2024 •
edited
Loading

closes #7944

@swathipil swathipil force-pushed the swathipil/pyapi/add-py-tspconfig branch from 359b9d3 to 410f978 Compare November 13, 2024 18:37
@swathipil swathipil force-pushed the swathipil/pyapi/add-py-tspconfig branch from e3e4428 to c6033fe Compare December 17, 2024 22:21
swathipil
swathipil commented Dec 18, 2024
View reviewed changes
packages/python-packages/apiview-stub-generator/apistub/nodes/_argtype.py Outdated Show resolved Hide resolved
packages/python-packages/apiview-stub-generator/apistub/nodes/_class_node.py
apiview.add_line_marker(self.namespace_id, add_cross_language_id=True)
apiview.add_keyword("class", False, True)
apiview.add_text(self.full_name, definition_id=self.namespace_id)
line = review_lines.create_review_line(related_to_line=self.namespace_id)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: This decorator is not showing up in the staging diff. Check that that issue is fixed before deploying to prod.

@swathipil swathipil changed the title [Python APIView] update tspconfig for tree token parser [Python APIView] tree token parser Dec 18, 2024
@swathipil swathipil changed the title [Python APIView] tree token parser [Python APIView] tree token parser conversion Dec 18, 2024
@swathipil swathipil mentioned this pull request Dec 18, 2024
Draft
4 tasks
@tjprescott tjprescott self-requested a review January 6, 2025 21:39
tjprescott
tjprescott reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a big diff due to stuff being refactored into separate files, so I'm relying a lot on the tests continuing to pass. I do recommend adding logic to test the "context" feature to your tests.

packages/python-packages/apiview-stub-generator/README.md Outdated Show resolved Hide resolved
packages/python-packages/apiview-stub-generator/README.md Outdated Show resolved Hide resolved
packages/python-packages/apiview-stub-generator/tests/_test_util.py Outdated Show resolved Hide resolved
packages/python-packages/apiview-stub-generator/tests/apiview_test.py Outdated Show resolved Hide resolved
packages/python-packages/apiview-stub-generator/tests/apiview_test.py Show resolved Hide resolved
swathipil
swathipil commented Jan 14, 2025
View reviewed changes
packages/python-packages/apiview-stub-generator/CHANGELOG.md
@@ -1,5 +1,8 @@
# Release History

## Version 0.3.14 (Unreleased)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update release date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott approved these changes

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python APIView] parser support restructure for tree tokens
2 participants
@swathipil @tjprescott