Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] dedent rule #9669

Merged
merged 6 commits into from
Jan 22, 2025
Merged

[pylint] dedent rule #9669

merged 6 commits into from
Jan 22, 2025

Conversation

l0lawrence
Copy link
Member

@l0lawrence l0lawrence requested a review from Copilot January 21, 2025 21:22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py:3110

  • The check for :dedent: should ensure that it is followed by a value, indicating that it is hardcoded. Modify the check to re.search(r':dedent:\s*\d+', node.doc_node.value).
node.doc_node.value.find(":dedent") != -1

tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_files/dedent_failure.py:47

  • [nitpick] The class name 'Some1Client' is inconsistent with naming conventions. It should be renamed to 'SomeClient1' or something more descriptive.
class Some1Client():  # @

tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py:3905

  • The class name 'TestDeDent' is incorrectly capitalized. It should be renamed to 'TestDedent'.
class TestDeDent(pylint.testutils.CheckerTestCase):
@l0lawrence l0lawrence enabled auto-merge (squash) January 22, 2025 18:30
@l0lawrence l0lawrence merged commit 5144d2e into Azure:main Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pylint] dedent should never have a number
2 participants