Update C++ guidelines to explicitly state that client methods should be marked as const #8388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be marked as const
ahsonkhan
requested review from
JeffreyRichter,
LarryOsterman and
RickWinter
as code owners
LarryOsterman
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK clients are designed to be immutable as per the guidelines, so it should be safe to mark them as
constso that a user referencing client instances asconst&will be able to call any of the marked methods.Related issues/PRs:
Azure/azure-sdk-for-cpp#6328
https://github.com/Azure/autorest.cpp/issues/464
Azure/azure-sdk-for-cpp#6329
Azure/azure-sdk-for-cpp#6330