Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition compile for hard mute. #5543

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Fix condition compile for hard mute. #5543

merged 3 commits into from
Jan 10, 2025
+23 −5

Conversation

fuyan2024
Copy link
Member

@fuyan2024 fuyan2024 commented Jan 10, 2025 •
edited
Loading

What

1.Fix a condition compile, one line change
2.Fix comments on video gallery props

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@fuyan2024 fuyan2024 marked this pull request as ready for review January 10, 2025 00:51
@fuyan2024 fuyan2024 requested review from a team as code owners January 10, 2025 00:51
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-upaabfzunw.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fvvbqnpufm.chromatic.com/

@fuyan2024 fuyan2024 enabled auto-merge (squash) January 10, 2025 01:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27807 / 44245
62.84%		 27807 / 44245
62.84%		 780 / 1418
55%		 2330 / 3678
63.34%
Current 27888 / 44282
62.97%		 27888 / 44282
62.97%		 780 / 1418
55%		 2332 / 3695
63.11%
Diff 81 / 37
0.13%		 81 / 37
0.13%		 0 / 0
0%		 2 / 17
-0.23%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56174 / 92227
60.9%		 56174 / 92227
60.9%		 1153 / 2655
43.42%		 3414 / 5656
60.36%
Current 56307 / 92366
60.96%		 56307 / 92366
60.96%		 1154 / 2656
43.44%		 3405 / 5667
60.08%
Diff 133 / 139
0.06%		 133 / 139
0.06%		 1 / 1
0.02%		 -9 / 11
-0.28%

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1768952
  • Base size: 1768210
  • Diff size: 742

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dhmwcqooqu.chromatic.com/

@fuyan2024 fuyan2024 merged commit 713582e into main Jan 10, 2025
41 checks passed
@fuyan2024 fuyan2024 deleted the fuyan/fix-cc-hard-mute branch January 10, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@sonalisaxenacse12 sonalisaxenacse12 sonalisaxenacse12 approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuyan2024 @sonalisaxenacse12 @mgamis-msft @edwardlee-msft