Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

i_pi_smarc_imx8mp_plus-2 #551

Closed
wants to merge 2 commits into from
Closed

i_pi_smarc_imx8mp_plus-2 #551

wants to merge 2 commits into from

Conversation

ADLINK-COM
Copy link
Contributor

@ADLINK-COM ADLINK-COM commented Nov 13, 2023

Thank you for contributing to the IoT Plug and Play Models repository

📝 Please review this checklist before submission

  • 👀 The models submitted in this PR follow the DTDL Naming Guidelines for contributing to this repository.
  • 🕵️I have validated the models locally using the dmr-client command line tool.
  • ❗ I understand once the PR is approved, the models are considered immutable: any edits will require to submit new files.
  • ✨ When creating a new top level dtmi:namespace, I have completed the PR Info Template below.

⚡ PR validation steps are described in the tools Wiki.

PR Info Template

When submitting models to the repository we ask that you provide as much of the following meta information around your models and related devices as possible. This info will be used to improve the IoT Plug and Play ecosystem.

👇: Please replace the markdown comment examples with your own values.

Company Info

Info identifying your company (if applicable).

IoT Plug and Play Device Info

Info identifying your device.

Model Submission Goals

Info related to broader submission goals.

Code Owners & Reserved Names

Indicates GitHub alias entries to be added to the repo CODEOWNERS for the incoming model namespace. The codeowner is expected to be involved in subsequent DTDL model submissions against the same namespace.

This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

@ADLINK-COM ADLINK-COM requested a review from a team as a code owner November 13, 2023 03:15
@ADLINK-COM ADLINK-COM requested a review from jrdouceur November 13, 2023 03:15
@ADLINK-COM ADLINK-COM marked this pull request as draft November 13, 2023 03:27
@kenkkkkk
Copy link
Contributor

any further update for this case, it seems still be kept in open, not close

@rido-min
Copy link
Member

any further update for this case, it seems still be kept in open, not close

The PR is still marked as "In Draft", once you mark it as "Ready for Review", we will review it.

@rido-min rido-min marked this pull request as ready for review November 21, 2023 01:12
@rido-min
Copy link
Member

this PR is out of sync with the base branch and cannot be merged, can you rebase or create a new one?

@ADLINK-COM ADLINK-COM closed this Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants