Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legacy operations for multi-path scenario #2095

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add legacy operations for multi-path scenario #2095

wants to merge 3 commits into from

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented Jan 17, 2025

To proceed #234, add the legacy operation template into the library according to this design. It's almost the same as @markcowl 's design, except:

  1. Change the body name and doc for CustomPatchSync/CustomPatchAsync to align with those of ArmCustomPatchSync/ArmCustomPatchAsync.
  2. Change the DeleteAsync to DeleteWithoutOkAsync because its corresponding ArmResourceDeleteAsync is deprecated.

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Jan 17, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 17, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

Add legacy operations for multi-path scenario

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 17, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pshao25 @azure-sdk