Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CancellationToken for ValidateTokenAsync #2437

Closed
wants to merge 2 commits into from
Closed

Add CancellationToken for ValidateTokenAsync #2437

wants to merge 2 commits into from

Conversation

RojaEnnam
Copy link
Contributor

@RojaEnnam RojaEnnam commented Jan 4, 2024 •
edited by jennyf19
Loading

Adds CancellationToken to ValidateTokenAsync API. #2451

@RojaEnnam RojaEnnam requested review from jennyf19 and sruke January 4, 2024 19:23
westin-m
westin-m reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@westin-m westin-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for a solution to virtual method throwing an exception in abstract class

@keegan-caruso
Copy link
Contributor

pls rebase off of dev. I expect this to fail on baseline package validation.

keegan-caruso
keegan-caruso requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will likely fail baseline package validation.

@RojaEnnam RojaEnnam force-pushed the roennam/WilsonCancellationToken branch from 8ffd5c9 to 7d1196d Compare January 9, 2024 22:27
@keegan-caruso
Copy link
Contributor

I was wrong, it isn't failing, I guess because of the default implementation. But this is still breaking at runtime.

@jennyf19 jennyf19 added the IdentityModel8x Future breaking issues/features for IdentityModel 8x label Jan 16, 2024
@jennyf19 jennyf19 closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westin-m westin-m westin-m approved these changes

@keegan-caruso keegan-caruso keegan-caruso requested changes

@ciaozhang ciaozhang ciaozhang approved these changes

@jennyf19 jennyf19 Awaiting requested review from jennyf19

@sruke sruke Awaiting requested review from sruke

Assignees
No one assigned
Labels
IdentityModel8x Future breaking issues/features for IdentityModel 8x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RojaEnnam @keegan-caruso @ciaozhang @westin-m @jennyf19