Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating IDDP push to only push for nightly builds #2616

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

trwalke
Copy link
Member

@trwalke trwalke commented May 29, 2024

Updating IDDP push to only push to IDDP for nightly builds

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Updating the Upload to IDDP task to only run during nightly builds.
When WilsonVersion is set, upload will not happen

Working build (https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1307446&view=logs&j=15dfcb1a-0989-5cf6-3160-3e181e44de87)
image

Fixes #{bug number} (in this specific format)

@trwalke trwalke requested a review from a team as a code owner May 29, 2024 07:04
@trwalke trwalke changed the title Updating IDDP push to only push to IDDP for nightly builds Updating IDDP push to only push for nightly builds May 29, 2024
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @trwalke

@trwalke trwalke merged commit 7cdeadb into dev May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants