Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add framework for reducing exceptions and logging. #2628

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

brentschmaltz
Copy link
Member

This PR introduces an internal set of building blocks that will be used for capturing SecurityToken validation results in a consistent and deterministic manner.

We introduced the TokenValidationResult to avoid throwing back to the calling application on errors.
This work is an extension where each step captures and attaches the result to the TokenValidationResult.
All logs and exceptions are handled by upper layers.

This will be used to reduce throwing exceptions and logging.

When multiple security policies are associated with a single endpoint, for a successful validation, error logs will not be automatically written.

Latency is reduced as Exceptions are not thrown when one policy succeeds.

@brentschmaltz brentschmaltz requested a review from a team as a code owner June 11, 2024 21:26
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool, @brentschmaltz

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really well laid out. Thanks @brentschmaltz

@brentschmaltz brentschmaltz merged commit 78236a0 into dev Jun 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants