Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exceptions thrown during issuer validation. Add validation source. #2643

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Jun 18, 2024

Issuer validation: Remove exceptions and add validation source

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Removed ArgumentNullException thrown as part of issuer validation, and added source.

Description

  • Replaced instances that threw ArgumentNullException with a return of IssuerValidationResult containing the exception information.
  • Addressed TODO around identifying the source of the issuer validation (configuration, validation parameters: valid issuer or among list of valid issuers).
  • Added tests around all the previous cases.

@iNinja iNinja requested a review from a team as a code owner June 18, 2024 16:16
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to generalize ValidationSource.
We should also consider other validators before we make a choice.

@iNinja iNinja merged commit 0c13bf0 into dev Jun 18, 2024
4 checks passed
@iNinja iNinja deleted the iinglese/validate-issuer-remove-exceptions-add-source branch November 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants