Algorithm validation: Remove exceptions #2697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westin-m
reviewed
Jul 10, 2024
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Algorithm.cs
Outdated
Show resolved
Hide resolved
westin-m
reviewed
Jul 10, 2024
test/Microsoft.IdentityModel.Tokens.Tests/Validation/AlgorithmValidationResultTests.cs
Outdated
Show resolved
Hide resolved
…ValidationResultTests.cs Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
…ithm.cs Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
westin-m
approved these changes
Jul 10, 2024
* Serialize byte arrays as base64 strings in JsonWebToken and JwtSecurityToken Fixes #2524 --------- Co-authored-by: Keegan Caruso <keegancaruso@microsoft.com>
iNinja
requested changes
Jul 11, 2024
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Algorithm.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.Tokens.Tests/Validation/AlgorithmValidationResultTests.cs
Show resolved
Hide resolved
* Make IsNullOrEmpty internal * Make the extension method visible to SAML tests. * Make class internal. * Use string.IsNullOrEmpty where appropriate.
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Algorithm.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: joegoldman2 <147369450+joegoldman@users.noreply.github.com>
src/Microsoft.IdentityModel.Tokens/Validation/AlgorithmValidationResult.cs
Outdated
Show resolved
Hide resolved
* new api takes stream * rename method * remove usings * void when takes a stream, comment strings * add testing, add api to public namespace * review feedback
* Base for new ValidationParameters * Clean up new files. Keep the original validator code in Validators.cs --------- Co-authored-by: id4s <user@contoso.com>
…ValidationResultTests.cs Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
…ithm.cs Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
…AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet into francofung/NewAlgorithmDelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Algorithm validation: Remove exceptions
Description