Add CaseSensitiveClaimsIdentity to 7x #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
keegan-caruso
commented
Jul 15, 2024
keegan-caruso
commented
- Cherry pick Add CaseSensitiveClaimsIdentity type. #2700
- Made CaseSensitiveClaimsIdentity an opt-in
- Revert using CaseSensitiveClaimsIdentity by default in tests
* Add CaseSensitiveClaimsIdentity. Update JsonWebTokenHandler. * Move switch to a separate class. Update claims identity creation code. * Add test. * Update AppContextSwitches * Update test/Microsoft.IdentityModel.Tokens.Tests/CaseSensitiveClaimsIdentityTests.cs Co-authored-by: msbw2 <brettwhite@microsoft.com> * Update comments. * Update ClaimsIdentity code creation in src. * Add tests. * Update tests to use correct types. * Add SecurityToken property to CsClaimsIdentity. * Update tests to use CsClaimsIdentity. * Refactor code into ClaimsIdentityFactory. * Update tests. * Update ClaimsIdentityFactory. * Fix tests. * Update tests for CaseSensitiveClaimsIdentity * ignore SecurityToken in IdentityComparer * Set security token in ClaimsIdentityFactory. Add tests. * Apply suggestions from code review * Update test. --------- Co-authored-by: msbw2 <brettwhite@microsoft.com> Co-authored-by: Keegan Caruso <keegancaruso@microsoft.com>
pmaytak
reviewed
Jul 15, 2024
jennyf19
approved these changes
Jul 15, 2024
Co-authored-by: Peter <34331512+pmaytak@users.noreply.github.com>
pmaytak
reviewed
Jul 15, 2024
Co-authored-by: Peter <34331512+pmaytak@users.noreply.github.com>
…2716) * Call TVP.CreateClaimsIdentity to support users that have overloaded. * picked up SAML changes and TokenValidationResult * updated JwtSecurityTokenHandler, reverted tests and removed method. * touched up tests --------- Co-authored-by: id4s <user@contoso.com>
pmaytak
reviewed
Jul 16, 2024
src/Microsoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.cs
Outdated
Show resolved
Hide resolved
keegan-caruso
force-pushed
the
pmaytak/cs-claims-7x
branch
from
7edcbbf to
febd644
Compare
…enHandler.cs Co-authored-by: Peter <34331512+pmaytak@users.noreply.github.com>
pmaytak
reviewed
Jul 16, 2024
test/Microsoft.IdentityModel.Tokens.Saml.Tests/SamlSecurityTokenHandlerTests.cs
Show resolved
Hide resolved
pmaytak
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.