Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string comparison with differing timestamps #2739

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

msbw2
Copy link
Contributor

@msbw2 msbw2 commented Jul 22, 2024

Currently strings (specifically error strings) tend to contain timestamps which can include skew and thus not exactly match. This change extracts these timestamps and compares them with an epsilon to address flakiness caused by this skew.

@msbw2 msbw2 requested a review from a team as a code owner July 22, 2024 22:44
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 added this to the 8.0.1 milestone Jul 22, 2024
@msbw2
Copy link
Contributor Author

msbw2 commented Jul 22, 2024

@msbw2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@jennyf19 jennyf19 merged commit e67b25b into dev Jul 22, 2024
4 checks passed
@msbw2 msbw2 deleted the brettwhite/fix-string-timestamp-comparison branch July 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants