Update common.props

[ciaozhang]

Suppress warning:
##[warning]C:\Users\ContainerAdministrator.nuget\packages\microsoft.bcl.memory\9.0.0\buildTransitive\netcoreapp2.0\Microsoft.Bcl.Memory.targets(4,5): Warning : Microsoft.Bcl.Memory 9.0.0 doesn't support net6.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set true in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.

https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1410786&view=logs&j=15dfcb1a-0989-5cf6-3160-3e181e44de87&t=32ee994e-3d32-5011-f0cb-438d28090217

[jmprieur]

Let's suppress this warning in a more targeted manner, otherwise we might miss future warnings

[github-actions]

Summary

Summary

Generated on:	1/7/2025 - 7:56:35 PM
Coverage date:	1/7/2025 - 7:46:22 PM - 1/7/2025 - 7:56:08 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%

[github-actions]

Summary

Summary

Generated on:	1/7/2025 - 8:11:43 PM
Coverage date:	1/7/2025 - 8:01:51 PM - 1/7/2025 - 8:11:18 PM
Parser:	MultiReport (60x Cobertura)
Assemblies:	1
Classes:	7
Files:	2
Line coverage:	80.3% (620 of 772)
Covered lines:	620
Uncovered lines:	152
Coverable lines:	772
Total lines:	483
Branch coverage:	67.8% (228 of 336)
Covered branches:	228
Total branches:	336
Method coverage:	Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%

Name	Line	Branch
Microsoft.IdentityModel.JsonWebTokens	80.3%	67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities	100%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated	80.3%	67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0	81.4%	67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1	79.2%	68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3 CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0	81.4%	67.6%

[jmprieur]

I'm assuming the risk is mitigated as we run all the tests in .NET 6.
Why do we reference 9.x packages ? where does this come from? Is it something we should only do in the net9.0 target framework

[ciaozhang]

I'm assuming the risk is mitigated as we run all the tests in .NET 6. Why do we reference 9.x packages ? where does this come from? Is it something we should only do in the net9.0 target framework.

it is from
c0eb23c#diff-fe95b71339300cd58f4eab448dc069e28ca64a4d25c3c67e847dfafcf44c31d9

[jmprieur]

Ok. So I see that we reference:

Microsoft.Bcl.Memory for the Base64Encoding.

How was the PR merged in the first place?

[ciaozhang]

How was the PR merged in the first place?
The current PR build doesn't check for warning, that is why we need onebranch PR build

[pmaytak]

Ok. So I see that we reference:

Microsoft.Bcl.Memory for the Base64Encoding.

How was the PR merged in the first place?

The checks passed. Looks like we just don't run this ADO build on PRs.